Skip to content

fix: change container sync status icon [FC-0097] #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2025
Merged

fix: change container sync status icon [FC-0097] #2360

merged 2 commits into from
Aug 18, 2025

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Aug 7, 2025

Description

This PR changes the sync icon for Sections, Subsections, and Units in case the Upstream source is deleted.

image

Useful information to include:

  • Which user roles will this change impact?
    "Course Author",

Supporting information

Testing instructions

  • Create a structure with a Section, Subsection, and Unit in a library
  • Add the Section to a course
  • Delete the Section on the library and check that the sync icon changes

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 7, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @rpenido!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Aug 7, 2025
@rpenido rpenido force-pushed the rpenido/fal-4227/change-sync-status-icon branch 3 times, most recently from 763fa85 to 1686698 Compare August 7, 2025 23:06
@codecov Codecov
Copy link

codecov bot commented Aug 7, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.49%. Comparing base (b2203f0) to head (f195c18).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2360      +/-   ##
==========================================
+ Coverage   94.47%   94.49%   +0.02%     
==========================================
  Files        1169     1171       +2     
  Lines       25136    25144       +8     
  Branches     5494     5373     -121     
==========================================
+ Hits        23748    23761      +13     
- Misses       1317     1320       +3     
+ Partials       71       63       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rpenido rpenido force-pushed the rpenido/fal-4227/change-sync-status-icon branch 4 times, most recently from cd153e5 to ed81755 Compare August 12, 2025 20:57
navinkarkera
navinkarkera approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@navinkarkera navinkarkera left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido 👍 Looks good.

  • I tested this: (Verified icon after deleting upstream blocks)
  • I read through the code
  • I checked for accessibility issues (We don't have any hover message for these links, it would be good to add them if possible)
  • Includes documentation

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready to Merge in Contributions Aug 14, 2025
@rpenido rpenido force-pushed the rpenido/fal-4227/change-sync-status-icon branch 8 times, most recently from 2859388 to e7555de Compare August 14, 2025 23:18
@rpenido rpenido force-pushed the rpenido/fal-4227/change-sync-status-icon branch from e7555de to f195c18 Compare August 15, 2025 02:54
@rpenido rpenido changed the title fix: change container sync status icon fix: change container sync status icon [FC-0097] Aug 15, 2025
@ChrisChV ChrisChV merged commit 2c9f90b into openedx:master Aug 18, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Merge to Done in Contributions Aug 18, 2025
@ChrisChV ChrisChV deleted the rpenido/fal-4227/change-sync-status-icon branch August 18, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisChV ChrisChV ChrisChV approved these changes

+1 more reviewer

@navinkarkera navinkarkera navinkarkera approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rpenido @openedx-webhooks @navinkarkera @ChrisChV